chore: update @rocicorp/eslint-config to 0.7.0 #3571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
grgbkr
commented
Jan 20, 2025
| @@ -244,9 +244,11 @@ export async function runUntilKilled( | |||
| export async function exitAfter(run: () => Promise<void>) { | |||
| try { | |||
| await run(); | |||
| // eslint-disable-next-line no-console | |||
There was a problem hiding this comment.
Should these be using the lc: LogContext rather than console?
There was a problem hiding this comment.
I couldn't immediately think of an elegant way to do that. These are top-level wrappers that call the methods that create the LogContext ...
|
Bencher Report| Branch | grgbkr/eslint-update |
| Testbed | localhost |
Click to view all benchmark results
| Benchmark | Throughput | Benchmark Result operations / second (ops/s) (Result Δ%) | Lower Boundary operations / second (ops/s) (Limit %) |
|---|---|---|---|
| src/client/zero.bench.ts > basics > All 1000 rows x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 70.69 (-2.59%) | 68.94 (97.53%) |
| src/client/zero.bench.ts > with filter > Lower rows 500 x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 93.86 (+0.37%) | 88.84 (94.65%) |
|
| Branch | grgbkr/eslint-update |
| Testbed | localhost |
Click to view all benchmark results
| Benchmark | File Size | Benchmark Result kilobytes (KB) (Result Δ%) | Upper Boundary kilobytes (KB) (Limit %) |
|---|---|---|---|
| zero-package.tgz | 📈 view plot 🚷 view threshold | 899.51 (+0.00%) | 917.46 (98.04%) |
| zero.js | 📈 view plot 🚷 view threshold | 171.19 (-0.01%) | 174.63 (98.03%) |
| zero.js.br | 📈 view plot 🚷 view threshold | 47.67 (+0.02%) | 48.61 (98.06%) |
darkgnotic
reviewed
Jan 21, 2025
| @@ -244,9 +244,11 @@ export async function runUntilKilled( | |||
| export async function exitAfter(run: () => Promise<void>) { | |||
| try { | |||
| await run(); | |||
| // eslint-disable-next-line no-console | |||
There was a problem hiding this comment.
I couldn't immediately think of an elegant way to do that. These are top-level wrappers that call the methods that create the LogContext ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular this pull in "no-console".