fix(zero): Do not "bundle" change-protocol #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server part of zero is not bundled using esbuild. It is just compiled using tsc and the code structure maps the source code structure. Followup to #3491
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Bencher Report| Branch | arv/zero-build-fix |
| Testbed | localhost |
Click to view all benchmark results
| Benchmark | File Size | Benchmark Result kilobytes (KB) (Result Δ%) | Upper Boundary kilobytes (KB) (Limit %) |
|---|---|---|---|
| zero-package.tgz | 📈 view plot 🚷 view threshold | 961.55 (-1.14%) | 1,021.25 (94.15%) |
| zero.js | 📈 view plot 🚷 view threshold | 186.10 (-1.64%) | 198.66 (93.68%) |
| zero.js.br | 📈 view plot 🚷 view threshold | 52.05 (-0.94%) | 55.18 (94.34%) |
|
darkgnotic
reviewed
Jan 13, 2025
There was a problem hiding this comment.
The change-protocol is intended to be an interface between zero-cache and custom upstream providers (like the one @cbnsndwch is building for Mongo). So the intention is allow developers to reference these classes in their implementations, like:
What's the right way to do that?
|
The code in your screenshot works with this PR. I think we should change it to: import {ChangeSourceDownstream} from '@rocicorp/zero/change-protocol/v0'; |
Ah, got it. So the "exports" in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server part of zero is not bundled using esbuild. It is just compiled using tsc and the code structure maps the source code structure.
Followup to #3491