limit morphic to trivial analysis to avoid inplace mutation bugs #7370
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surprisingly this actually increases perf of some benchmarks. My guess is that it fixes bugs during looping and thus reduces work. Specifically cFold and derive see minor gains ~1.5%; rBTreeCk sees a big gain ~4%. NQueens is the only benchmark that sees a lost at ~2%. False interpreter also see a 0-5% perf improvement depending on the exact input. That said, the improvement was noisy. ref #7367
Anton-4
requested changes
Dec 14, 2024
| @@ -358,7 +358,9 @@ where | |||
|
|
|||
| match opt_level { | |||
| OptLevel::Development | OptLevel::Normal => morphic_lib::solve_trivial(program), | |||
| OptLevel::Optimize | OptLevel::Size => morphic_lib::solve(program), | |||
| // TODO(#7367): Change this back to `morphic_lib::solve`. | |||
There was a problem hiding this comment.
Should we keep this comment given that it is faster?
There was a problem hiding this comment.
Put a lot more detail into the todo. My gut feeling is that we want full morphic in the long run, but the bug is leading to it having worse perf than it should. I would guess that once the bug is fixed, we will be able to find cases with solid perf wins from morphic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly this actually increases perf of some benchmarks. My guess is that it fixes bugs during looping and thus reduces work. Specifically cFold and derive see minor gains ~1.5%; rBTreeCk sees a big gain ~4%. NQueens is the only benchmark that sees a lost at ~2%.
False interpreter also see a 0-5% perf improvement depending on the exact input. That said, the improvement was noisy.
ref #7367