Fix false interpreter #7369
Open
Fix false interpreter #7369
+383
−557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smores56
previously approved these changes
Dec 14, 2024
| @@ -11,132 +11,124 @@ import Variable exposing [Variable] | |||
| # It has some extra constraints: | |||
| # 1) The input files are considered too large to just read in at once. Instead it is read via buffer or line. | |||
| # 2) The output is also considered too large to generate in memory. It must be printed as we go via buffer or line. | |||
|
|
|||
| # All of the notes below this line are hopefully outdated with purity inference. | |||
There was a problem hiding this comment.
nitpick: maybe prefix this with a TODO so we remember to remove the outdated notes if this successfully fixes the issue they point out?
There was a problem hiding this comment.
Good call. Removed. I think it is all resolved.
There was a problem hiding this comment.
Also, false feels surprisingly snappy for what it is.
smores56
approved these changes
Dec 14, 2024
bhansconnect
force-pushed
the
fix-false
branch
from
8c25728 to
397e804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets the false interpreter upgraded to purity inference, cleaned up in general, and running as a test again.