forked from open-telemetry/opentelemetry-python
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1174 zipkin exporter v1 thrift support #2
Open
robwknox
wants to merge
27
commits into
1173_zipkin_exporter_v1_json_support_fix
Choose a base branch
from
1174_zipkin_exporter_v1_thrift_support
base: 1173_zipkin_exporter_v1_json_support_fix
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
1174 zipkin exporter v1 thrift support #2
robwknox
wants to merge
27
commits into
1173_zipkin_exporter_v1_json_support_fix
from
1174_zipkin_exporter_v1_thrift_support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4_zipkin_exporter_v1_thrift_support
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…ncation with thrift-based exporters
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…exporter_v1_thrift_support
…kin_exporter_v1_thrift_support
…kin_exporter_v1_thrift_support
robwknox
changed the base branch from
1173_zipkin_exporter_v1_json_support
to
1173_zipkin_exporter_v1_json_support_fix
December 3, 2020 21:35
…kin_exporter_v1_thrift_support
…kin_exporter_v1_thrift_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the Zipkin Exporter v1 API thrift format.
Important note on Trace and Span IDs
Thrift only supports signed integers (max 64 bits). This results in the Zipkin Thrift API having type definitions of:
The default OTEL
RandomIdsGenerator
class generates unsigned integers of 64-bits (span) and 128-bits (trace). This results in default behavior of integer overflow during encoding ~50% of the time for Span IDs and ~75% for Trace IDs. Not a practical situation so the code provides two solutionsThriftRandomIdsGenerator
has been provided to override the default OTEL generator. This slightly reduces the size of the generated IDs (63-bit for span / 126-bit for trace) in order to enusre they will fit into the thrift data types.Fixes open-telemetry#1174
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: