Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate ReporterFactory and property reporter #836

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

robstoll
Copy link
Owner


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

@robstoll robstoll force-pushed the deprecate-ReporterFactory branch from f924c86 to fa36801 Compare March 16, 2021 21:52
@robstoll robstoll force-pushed the deprecate-ReporterFactory branch from fa36801 to 30f812e Compare March 16, 2021 22:07
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #836 (30f812e) into master (ac64df9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #836   +/-   ##
=======================================
  Coverage   86.26%   86.26%           
=======================================
  Files         462      462           
  Lines        4559     4559           
  Branches      266      266           
=======================================
  Hits         3933     3933           
  Misses        562      562           
  Partials       64       64           
Flag Coverage Δ
bbc 75.84% <100.00%> (ø)
bc 77.75% <100.00%> (ø)
current 83.54% <100.00%> (ø)
current_windows 82.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lin/ch/tutteli/atrium/reporting/ReporterFactory.kt 60.00% <ø> (ø)
...core/robstoll/lib/reporting/OnlyFailureReporter.kt 75.00% <ø> (ø)
...ium/creating/impl/ComponentFactoryContainerImpl.kt 93.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac64df9...30f812e. Read the comment docs.

@robstoll robstoll merged commit 2a38856 into master Mar 17, 2021
@robstoll robstoll deleted the deprecate-ReporterFactory branch March 17, 2021 06:04
@robstoll robstoll linked an issue Mar 18, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor core, don't use ServiceLoader
1 participant