Move reporter builder #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ComponentFactory because we need a way to say we want kind of a
singleton which is re-used in this ComponentFactoryContainer.
We cannot / don't want to make guarantees about creating a singleton
only once, i.e. use computeIfAbsent or similar, because it would mean
we cannot have a singleton component which depends on another
singleton component.
We try at least to create a singleton as less as possible. For this to
work:
- introduce ComponentFactory (as already mentioned)
- let ComponentFactoryContainer.getFactoryOrNull and
getFactoryForChainedOrNull return a ComponentFactory instead of a
simple function
- introduce ConcurrentMap as polyfill
moreover:
- deprecate get/setAtriumProperty and ReporterFactory
- deprecate all Translator and AssertionFormatter specific stuff in
core-robstoll-lib and move to core
- configure replacements in DefaultComponentFactoryContainer
- get rid off most ReporterFactories only keep DefaultReporterFactory
which we will remove with 0.17.0
- rename RemoveRunnerAtriumError to RemoveRunnerFromAtriumError
- move text specific AssertionFormatter to package `text` as preparation
for further AssertionFormatters (like html)
- introduce RealTranslatorIntSpec which makes use of
ComponentFactoryContainer instead of ReporterFactory
Codecov Report
@@ Coverage Diff @@
## master #818 +/- ##
==========================================
+ Coverage 84.74% 86.18% +1.43%
==========================================
Files 437 462 +25
Lines 4222 4523 +301
Branches 225 262 +37
==========================================
+ Hits 3578 3898 +320
+ Misses 596 563 -33
- Partials 48 62 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part 1 of 2 (I guess) what is missing is to move the Reporter as well
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.