-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add samples for optionalExpectations of api-fluent #917
Comments
I'll work on this.But i have no idea ,how this gonna happen.But i want to try this once |
can u tell me how to start....i m new to github...and opensource too |
See above, the link |
unable to find ListExpectationSamples |
Have you forked and cloned the project? You should find it easily via search function of your IDE |
yes i forked and cloned it.and also foundListExpectationSamples.Now what to do next..i mean what r the function to be made? |
See the description of this issue. it's more or less a one to one step description. Have you created the OptionalExpectationSamples? Once done you do the next step etc. |
Yes i made it ....i will try to do it ....and communicate further...if i
would not able to do that ...
…On Tue, 25 May 2021, 1:17 pm Robert Stoll, ***@***.***> wrote:
See the description of this issue. it's more or less a one to one step
description. Have you created the OptionalExpectationSamples? Once done you
do the next step etc.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#917 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO22KDEXCRVZQ3LGVXZBRKLTPNIYZANCNFSM45K64ADA>
.
|
In case you run into another problem, then create a draft PR please. This way I see what you have already done and thus better understand what next step you try to achieve. |
@ArcaneOP do you need help? |
I have exams....i will start after 10th..sorry for inconvenience..
…On Mon, 7 Jun 2021, 2:01 pm Robert Stoll, ***@***.***> wrote:
@ArcaneOP <https://github.com/ArcaneOP> do you need help?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#917 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO22KDB6R2I3EJS5R23NPZDTRR7U7ANCNFSM45K64ADA>
.
|
No problem at all, no rush, just wanted to be sure you don't have obstacles on the way 🙂 |
Thank you! For giving me time🙂
…On Mon, 7 Jun 2021, 2:23 pm Robert Stoll, ***@***.***> wrote:
No problem at all, no rush, just wanted to be sure you don't have
obstacles on the way 🙂
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#917 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO22KDDWXLFNYVMZDZVPNWTTRSCHDANCNFSM45K64ADA>
.
|
I'll work on this, seems like the previous person's account got deleted. Assign it if OK. |
@timacosta do you need help with this? |
@robstoll just didn't manage to take over on this yet. Will do this week if there is no rush! If any I'll let you know. |
No rush at all |
@robstoll I've started slowly on this one (didn't have any time until now) and I was wondering how complex you expect these samples to be. I was just dealing a bit with the different functions in Let me know and clarify if needed, what kind of use cases are you expecting and I can elaborate from there. Here is what I did just messing around, simple. @Test
fun toBeEmpty() {
val empty: String? = null
val opt = Optional.ofNullable(empty)
expect(opt).toBeEmpty()
}
@Test
fun toBePresent() {
val notEmpty: String? = "toBePresent"
val opt = Optional.ofNullable(notEmpty)
expect(opt).toBePresent()
}
|
Rather simple, take a look at other examples. It's always good to have a passing and a failing sample. |
Code related feature
With this issue we want to add samples for optionalExpectations.kt of api-fluent
Following the things you need to do:
api-fluent
Feature
to the function name of the one not expectingassertionCreator
(see ListExpectationSamples)@sample
(check outtoEqual
in anyExpectations.kt to see how you have to refer to the sample)Your first contribution?
I'll work on this
if you would like to take this issue over.This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
(Invite yourself in case you do not have an account yet).
The text was updated successfully, but these errors were encountered: