Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build Atrium against jdk13 and jdk14 #451

Closed
2 tasks
robstoll opened this issue Apr 19, 2020 · 4 comments · Fixed by #454
Closed
2 tasks

build Atrium against jdk13 and jdk14 #451

robstoll opened this issue Apr 19, 2020 · 4 comments · Fixed by #454
Milestone

Comments

@robstoll
Copy link
Owner

Platform (jvm, js, android):
Extension (none, kotlin 1.3, jdk8): none

Code related feature

We want to check if Atrium builds against jdk13 and jdk14
We already tried and saw that some tests fail as there is an issue with mockk.

Following the things you need to do:

@robstoll
Copy link
Owner Author

robstoll commented Apr 19, 2020

Most likely mockk does not support jdk13 and jdk14 yet. I opened a bug: mockk/mockk#428

@robstoll robstoll removed the good first issue Good for newcomers label Apr 19, 2020
@oleksiyp
Copy link

I did a few commits today to MockK develop branch and test on JDK 13/14. Seems everything works. The current issue is with dokka. Not sure how am going to release it

@robstoll
Copy link
Owner Author

Thanks for the heads up, is there already an issue for dokka? I couldn't find any in a hurry, I would upvote it.

@oleksiyp
Copy link

This is quite a long-running issue. Kotlin/dokka#294

robstoll added a commit that referenced this issue Apr 20, 2020
@robstoll robstoll added this to the 0.12.0 milestone May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants