Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates documentation to have a full working example. #335

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

xavier-contreras
Copy link
Collaborator

  • Updates all docs and code references to local-routing to network-instance instead
  • Updates generate_bindings.sh to clone the models repo entirely since models will keep changing making this a slightly more future proof way to reference models and generate bindings

* Updates all docs and code references to local-routing to 
network-instance instead
* Updates generate_bindings.sh to clone the models repo entirely since 
models will keep changing making this a slightly more future proof way 
to reference models and generate bindings
```
black --line-length 119 static_route_example.py 
reformatted static_route_example.py

All done! ✨ 🍰 ✨
1 file reformatted.
```
@xavier-contreras
Copy link
Collaborator Author

Fixes #334

Copy link
Collaborator

@JoseIgnacioTamayo JoseIgnacioTamayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest a few small improvements to the shell script.

Copy link
Collaborator

@JoseIgnacioTamayo JoseIgnacioTamayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier-contreras xavier-contreras merged commit 7613086 into robshakir:master Jan 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants