Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More unittest conversions #167

Merged
merged 5 commits into from
Mar 30, 2018

Conversation

tarkatronic
Copy link
Collaborator

Converted the following to unittest:

  • leaf-list
  • nested-containers
  • openconfig-bgp-juniper
  • submodules

Copy link
Owner

@robshakir robshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again -- one minor typo, but this LGTM!

"leaf-list of union type had invalid result (%s != %s for %s)" \
% (passed, i[1], i[0])
allowed = False
self.assertFalse(allowed, "An erroneous value was assigned to the list (restircted type)")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/restircted/restricted/

@robshakir robshakir merged commit c0aa7d6 into robshakir:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants