Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed subdevice parameter in device wrappers implementations #3011

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Removed subdevice parameter in device wrappers implementations #3011

merged 4 commits into from
Feb 7, 2024

Conversation

randaz81
Copy link
Member

@randaz81 randaz81 commented Aug 30, 2023 •
edited
Loading

The individual implementations of the parameter subdevice have been removed from all yarp wrapper devices.
Depends on #3079
Discussed in details in #3078

@randaz81 randaz81 self-assigned this Aug 30, 2023
@randaz81 randaz81 added this to the YARP 4.0.0 milestone Aug 30, 2023
@randaz81 randaz81 temporarily deployed to code-analysis August 30, 2023 16:02 — with GitHub Actions Inactive
@randaz81 randaz81 modified the milestones: YARP 4.0.0, YARP 3.10.0 Aug 30, 2023
@update-docs
Copy link

update-docs bot commented Aug 30, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

@randaz81 randaz81 temporarily deployed to code-analysis August 30, 2023 20:36 — with GitHub Actions Inactive
@randaz81 randaz81 temporarily deployed to code-analysis August 31, 2023 08:17 — with GitHub Actions Inactive
@randaz81 randaz81 modified the milestones: YARP 3.10.0, YARP 3.11.0 Sep 19, 2023
@randaz81 randaz81 force-pushed the master branch 3 times, most recently from 71900d2 to ead1caf Compare November 30, 2023 12:46
@randaz81 randaz81 modified the milestones: YARP 3.11.0, YARP 3.10.0 Feb 5, 2024
@randaz81 randaz81 changed the title Removed subdevice parameter Removed subdevice parameter in device wrappers implementations Feb 5, 2024
@randaz81
the individual implementations of parameter subdevice have been rem…
994722a 
…oved from all yarp wrapper devices.

It will be reintroduced at a different level shared by all devices.
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

29.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@robotology robotology deleted a comment from traversaro Feb 7, 2024
@randaz81 randaz81 merged commit 0bf49fb into robotology:master Feb 7, 2024
41 of 50 checks passed
@randaz81 randaz81 deleted the subdevice_removed branch November 12, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro Awaiting requested review from traversaro traversaro is a code owner

@Nicogene Nicogene Awaiting requested review from Nicogene Nicogene is a code owner

Assignees

@randaz81 randaz81

Labels
Component: Devices
Projects
None yet
Milestone
YARP 3.10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@randaz81