Three boards receiver can now read the control mode #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfussi66
changed the title
This should be commented out somehow in the model to indicate that it is not generally available. Well, actually I would remove it as there won't be anything related in the architectural model. |
pattacini
requested changes
Mar 30, 2023
There was a problem hiding this comment.
Hi @mfussi66
Sorry, I didn't realize that the base branch of the PR is robotology:test/direct_current.
This branch will be removed soon, so there's no use to push there.
You may want to rebase the PR against devel1 and remove the
Footnotes
-
Don't close this PR, just change the base branch. ↩
mfussi66
force-pushed
the
test/direct_current
branch
from
c2df29b to
7fc2a6d
Compare
|
@pattacini I removed the Id logging as requested in the latest commit, maybe we can change the target branch to |
mfussi66
changed the title
pattacini
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the reading of the control Mode of the amcbldc boards in the three boards receiver Simulink model.
Together with it, it is also possible to read the direct current Id, for only diagnostic purposes.