ControlBoardDriverCoupling: add couplings for hand mk5 #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have any reference/document describing the coupling laws of the hands? We can merge also without it, even if in that case it is not easy to review the equations. |
traversaro
reviewed
Jan 11, 2023
Jot down a note for this in icub-tech-iit/documentation#246. |
Nicogene
force-pushed
the
feat/addHandMK5Coupling
branch
from
ca32724 to
4c46cfd
Compare
mfussi66
approved these changes
Jan 13, 2023
I fixed the conda failure, when the CI is happy can we merge and release v4.6.0 @Nicogene ? |
Ok for me! |
traversaro
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hand Mk4 and mk5 only differ in the
thumb_rotatethat has been removed in the last revision of the hand (see https://icub-tech-iit.github.io/documentation/hands/hands_mk5/)This has been tested with ergocub urdf