Fixed initialization of the local simulation time from Gazebo simTime on first call of onUpdate #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zebo simTime on first call of onUpdate().
|
Thanks, can you add a reference to this PR in the Changelog? Thanks! |
|
The CI is failing due to actions/runner-images#675, please ignore it, thanks. |
on it... |
nunoguedelha
changed the title
|
|
|
Ciao @traversaro , is anything else missing before you can approve? |
traversaro
approved these changes
Apr 21, 2020
Nothing is missing, we can merge. Just to explain why this was stack: I don't have notifications for new commit in the PR, so unless someone comments in the PR I have no way to know if the review comments have been addressed. |
traversaro
deleted the
fix/issue475-Wrong-init-of-stepTime-in-controlBoardDriver-onDevel
branch
traversaro
restored the
fix/issue475-Wrong-init-of-stepTime-in-controlBoardDriver-onDevel
branch
nunoguedelha
deleted the
fix/issue475-Wrong-init-of-stepTime-in-controlBoardDriver-onDevel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #475.
Refer to the analysis in the respective issue.