Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relativeMove implementation #466

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Fix relativeMove implementation #466

merged 1 commit into from
Mar 5, 2020

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Mar 4, 2020 •
edited
Loading

GazeboYarpControlBoardDriver::relativeMove was not correctly implemented until now.
See https://www.yarp.it/classyarp_1_1dev_1_1IPositionControl.html#a32763b9f36c8751b589b23ff79915e0b for the documentation on how the yarp::dev::IPositionControl::relativeMove method should be implemented.

Fix #465 .

@traversaro traversaro mentioned this pull request Mar 4, 2020
Closed
@traversaro traversaro requested a review from lrapetti March 4, 2020 20:32
@traversaro
Fix relativeMove implementation
5a17b16 
relativeMove was not correctly implemented until now
Fix #465
@traversaro
Copy link
Member Author

Thanks @lrapetti !

@traversaro traversaro merged commit 374ced4 into master Mar 5, 2020
@traversaro traversaro deleted the fix/465 branch March 5, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrapetti lrapetti lrapetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iCub: iPositionControl: relativeMove execute correctly but not move the joints
2 participants
@traversaro @lrapetti