Adjust integer config values to double #876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value for
squelch_db
was previously read from the config file as a double, and is later used as a double during recorder setup. Updating the default value would restore this behavior, and avoid truncating downward to an integer.The value for
callTimeout
has previously been read from the config file as an integer, but the json library is now truncating the value instead of rounding. Reports such as #875, and similar discussions on the discord, seem to indicate that users have been setting decimal values for this under one second, and the fact that it is now truncating down to 0 is causing multiple unexpected issues.Much like other call-shaping parameters (
minDuration
,maxDuration
, andminTransmissionDuration
),callTimeout
should also allow decimal values. Adjusting the type in the config struct would correct this.