Fix SoapySDRPlay3 edgecase #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2023
In this case per https://github.com/pothosware/SoapySDRPlay3/blob/534a173996b0ca2a88ff1931950c869d244c90f8/Settings.cpp#L517, the autogain must be disabled before setting the gain.
|
Wow - That is weird corner case. I will also make this change in the config branch I am working on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #689 when using https://github.com/pothosware/SoapySDRPlay3.
I have an SDRPlay device and a set of Docker images using SoapySDRPlay3 and the newer SDRPlay API. This works great with only this minor code change due to an edgecase with the SoapySDRPlay3 API.
In this case per https://github.com/pothosware/SoapySDRPlay3/blob/534a173996b0ca2a88ff1931950c869d244c90f8/Settings.cpp#L517, the autogain must be disabled before setting the gain to avoid gain not being set.
I've added a new call to
source->set_gain_mode(agc);as opposed to repositioning the existing call to ensure compatibility with other devices isn't affected.I didn't seem to be affected by this comment on the issue: #689 (comment) that required enabling AGC before disabling it.