Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create log file earlier #754

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

aaknitt
Copy link
Contributor

@aaknitt aaknitt commented Dec 23, 2022

Create log file earlier so that config and source creation info is logged to the file in addition to the console output.

Reference #723

Create log file earlier so that config and source creation info is logged to the file in addition to the console output.
@tadscottsmith
Copy link
Contributor

Good idea!

@robotastic
Copy link
Owner

It like it!

@robotastic robotastic merged commit e3b285e into robotastic:master Jan 14, 2023
@rosecitytransit
Copy link
Contributor

This needs to be reopened. The logging::add_file_log was duplicated instead of moved, so this effectively doesn't change anything. Also it would be ideal to be able to disable the console output (by not running

add_logs(boost::log::expressions::format("[%1%] (%2%) %3%") % boost::log::expressions::format_date_time<boost::posix_time::ptime>("TimeStamp", "%Y-%m-%d %H:%M:%S.%f") % boost::log::expressions::attr<boost::log::trivial::severity_level>("Severity") % boost::log::expressions::smessage);
). There's only a few lines that don't make it into the file log; mostly some that doesn't go through BOOST logging at all.

If you really want, I could open a PR for it.

rosecitytransit added a commit to rosecitytransit/trunk-recorder that referenced this pull request May 21, 2023
fix tbsk typo in p25_parser.cc

remove duplicate include line in p25_frame_assembler_impl.cc

remove duplicate add_file_log line in main.cc/have it capture log file config lines (fixes robotastic#754)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants