Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include boost/filesystem header #698

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

geezer85
Copy link
Contributor

@geezer85 geezer85 commented Jun 5, 2022

Without this include I get an error that boost::filesystem::create_directories is not declared while compiling this file.

@robotastic
Copy link
Owner

That is weird - is this with Arch Linux?
If so, I can try building it using this container: https://github.com/robotastic/trunk-recorder/blob/master/utils/Dockerfile.arch-latest.dev

@geezer85
Copy link
Contributor Author

geezer85 commented Jun 9, 2022

This is with Arch Linux. I see the error on an ARM SBC and in that container. I also ran across an issue with Arch's spdlog not bundling fmt. The suggested solution from a quick search was to define SPDLOG_FMT_EXTERNAL in cmake. I wrapped it in a test for the directory the header would be in so as to not break anyone else. For reference see this old issue.

@robotastic
Copy link
Owner

Cool! thanks for tracking this down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants