Remove nested BOOST_LOG_TRIVIAL to fix erroneous log level display #692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trunk-recorder, some
BOOST_LOG_TRIVIAL(info)
entries are showing as trace even when the log level is set at info.As noted here, nested BOOST_LOG_TRIVIAL calls override the severity display of the parent call.
This is commonly seen in "Concluding Recorded Call" messages and other things displaying "Last Update: X s" because
Call_impl::since_last_update()
has aBOOST_LOG_TRIVIAL(trace)
while passing back the integer result.There may be other nested boosts to uncover, but this one was fairly prevalent since it occurs at least once with each call.