Add initial support for gnuradio 3.10. #682
Conversation
|
Hum. Just to be a little weary of this. The current version of gnuradio on the latest version of Raspberry Pi OS (64bit) Bullseye (Debian 11 based) still downloads |
|
Awesome! I have to find a way to run GR 3.10 to test against. I will go create a Dev Container to test inside of. |
|
Weirdly even Debian (both the arm64 and amd64 builds) still has 3.8 as their default installed version. I just installed Debian on a MiniForum AMD 5800H and it has the exact same version of the Raspberry Pi 4s that I have setup. |
|
I just decommissioned 4 Raspberry Pi 4s. I'm going to install Ubuntu 22.04 LTS (arm64) onto one of them and try to do the build. I'll report back once done. |
|
Looks like the iomanip include in openmhz and rdio are not actually needed as well. But it builds cleanly with and without them. |
|
Builds cleanly on master, @geezer85 the only recommendation is removing the iomanip from the openmhz and Rdio plugin. It doesn't hurt, but it also doesn't seem to do anything. So if you have a reason for putting it in there if you could explain that would be helpful. Otherwise this all looks good to me and is ready to merged. Tested on Ubuntu 22.04 arm64 (GR 3.10) and Raspberry Pi OS arm64 (GR 3.8) with and without iomanip in the openmhz and Rdio plugins. |
| @@ -1,5 +1,8 @@ | |||
| #include <curl/curl.h> | |||
| #include <time.h> | |||
| #if GNURADIO_VERSION >= 0x030a00 | |||
| #include <iomanip> | |||
There was a problem hiding this comment.
Does not seem to be needed, but also doesn't hurt.
| @@ -1,5 +1,8 @@ | |||
| #include <curl/curl.h> | |||
| #include <time.h> | |||
| #if GNURADIO_VERSION >= 0x030a00 | |||
| #include <iomanip> | |||
There was a problem hiding this comment.
Does not seem to be needed, but also doesn't hurt.
|
I included it because on my setup I got a build error " 'setprecision' is not a member of 'std' " and including iomanip solved it. I only encountered it with GR 3.10. I'm building on Arch Linux ARM using the generic aarch64 image. Another header must be including it on the Pi, but not in Arch. It's probably more correct to check if the header was already included rather than check the GR version though since it's not really a GR issue. |
|
Oh interesting... what is a good way to solve this? We could just add iomanip.h with a check and it will just be ignored if it is being included through other paths. |
|
The iomanip header should have include guards to prevent multiple inclusions. |
|
Awesome!! Thanks for making these changes |
In gnuradio 3.10 the udp_sink "block" moved from gr::blocks to gr::network. This fixes the build failure caused by the move.