minor fix to unit answer reqest logging #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also logging source (caller)
rosecitytransit
force-pushed
the
v4master
branch
from
a5a0b3e to
7036348
Compare
from commit ce85cbc
|
This makes sense - good catch. That submission for control channel warn update rate also makes sense - could you add to the config.md document describing what this does? |
|
I'll definitely do so when I submit it. I need to put it together so it keeps the actual decoding rate checking at 3 seconds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looking at the merge commit, I saw that only one side's radio ID was being logged
Also, if you want, I can maybe add control channel decoding rate warning rate config ( 2d6a954 but I have it separated from the actual decoding rate check) to this PR