-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log data channel grants, unit answer requests, Location Reg Responses #661
Conversation
Cool - It would be helpful if you could break these up into separate requests. I am also about to merge in the I was thinking about adding in a Group check on the voice channel. I was going to send the Group down to the wav-sink using tags, similar to the way that SRC ID is done. All of the intelligence about a Transmission is living there now. I want to keep the OP25 code as close to the baseline as possible and also try not to put much intelligence there. I can work on implementing this approach soon. For alternate JSON files, it is best to do that as a plugin... that said, I really want to find a way to make it easier to have standalone plugins outside of the repo, so people can easily update them without me having to approve changes. |
Even though I've wasted way too much time trying to scratch the itch of getting the voice channel checking to work, I'll leave that out. I am hoping that it's not needed with the current version of the code. I haven't come across the issue of extraneous audio in the testing I've done so far; my hope is to update the running copy tonight. The other changes are pretty basic, just decoding and logging a few more trunking messages. As for the JSON thing, I'll just do that in my fork. Except for the overhead of having the individual files be written and then parsed, one could use the encoding script to get things how they want. Regarding the no-overlap branch, I tried it, but I unfortunately need the I really wish GitHub would allow you to submit patch files, instead of having to submit a copy of the entire code, though I am learning more about branching. |
610a327
to
dc4d7b5
Compare
originally added in commit ef68b5d
as CONFIGURE notes, the config.json script entry should contain the ./
Looks Good - thanks for whittling this down. |
-Decode and log tsbk 0x05 Unit to Unit Answer Requests and 0x14 SNDCP Data Channel Grants
-watch for different talk groups in a call on the voice channel (though I think the current master may negate the need for this; also I didn't actually stop the recording, just log it happening)
-update CONFIGURE.md unitScript entry
-undo #525; the issue is that the config.json entry needs to include a
./
if needed; it shouldn't be hard coded as if you want to run a program, there should be no./
at all.If you have issues with any of those, I can easily separate them out. Also, still want to put together/submit the ability to adjust the control channel decoding rate interval; see rosecitytransit@02969ee and rosecitytransit@59c89a1 and rosecitytransit@25376e7 Also might add the option to put the JSON data in a single, daily file instead of one for each call (if you're not uploading)