Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant improvements to audioplayer #549

Merged
merged 2 commits into from
Nov 28, 2021

Conversation

devicenull
Copy link
Contributor

This is a fairly large change to audioplayer.php that adds the following features:

  • Calls are retrieved via AJAX, and new calls are refreshed every 10s
  • Audio playback will continue automatically when new calls are found
  • Talk group selector was changed to use select2, which allows for searching the list of available call groups
  • The file can now be installed anywhere - it does not require being in the "utils" directory (as long as you use absolute paths in config.json, and update audioplayer.php with the path to the config file)

I added a couple more Javascript libraries here... It took some effort to not rewrite this entire file to use a proper templating library and source control, but I figured keeping this as a single file was important

@rosecitytransit
Copy link
Contributor

I actually have a "live" version that I made at https://github.com/rosecitytransit/trunk-recorder/tree/master/examples and discussed in #482

@robotastic
Copy link
Owner

Thanks @devicenull - I will merge this in.

@rosecitytransit - if you have some changes you want to make to the audio_player, that would be great. Could you open a PR for it? This is also a good reminder for me to look at the code in #482 and look into turning it into a plugin.

@robotastic robotastic merged commit c1db247 into robotastic:master Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants