Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title tag to m4a files? #369

Closed
dmonies327 opened this issue Jun 9, 2020 · 7 comments
Closed

Add title tag to m4a files? #369

dmonies327 opened this issue Jun 9, 2020 · 7 comments
Assignees

Comments

@dmonies327
Copy link

dmonies327 commented Jun 9, 2020

Is it possible to add a title tag to the m4a files created when uploading to openMHZ/broadcastify calls? I'd like to use these files with liquidsoap to stream to broadcastify as they are already balanced/normalized well, and there's no need to repackage the wav to mp3 just to add title comments if liquidsoap can play/stream the m4a/aac files (assuming this can also be done). I'd like them to have the TITLE tag on them, however.
If this isn't practical, does anyone know a good utility to quickly add the tag to the file that could be run in a separate script (similar to the way the encode_upload.sh does in the TR/LiquidSoap wiki writeup on RR)? I tried using id3v2 to add it, but it appears to just corrupt the files.
EDIT: I believe I found that I should be using mutagen to do this, but the original question still stands as to if trunk-recorder already has this functionality.

@EricTendian
Copy link
Contributor

There isn't that functionality currently available within trunk-recorder itself, since in https://github.com/robotastic/trunk-recorder/blob/master/trunk-recorder/uploaders/call_uploader.cc#L20 we are just converting the wav to a m4a. However, it looks like fdkaac does have an argument --title so it probably would be possible to modify the upload logic to include whatever alpha tag is associated with the talkgroup if it exists.

@robotastic robotastic self-assigned this Aug 4, 2020
@robotastic
Copy link
Owner

This is a good idea and should be a pretty easy change. I will add this to my list of things.

@natecarlson
Copy link
Contributor

natecarlson commented Nov 26, 2020

What content do you want in the tag?

Or in the ideal world should it be configurable, with placeholders for each of the major variables?

(It'd be absolutely trivial to hard code it to something; making it configurable would be a bit more work - at least for someone like me who can write C but kinda sucks at it.)

@dmonies327
Copy link
Author

dmonies327 commented Nov 26, 2020 via email

@robotastic
Copy link
Owner

I really have to add this - I thought I did at one point but I don't see it in the code

@kd4e
Copy link

kd4e commented Dec 14, 2024

I really have to add this - I thought I did at one point but I don't see it in the code

👍

robotastic added a commit that referenced this issue Dec 18, 2024
This should address #369
@robotastic
Copy link
Owner

Ok - it looks like it is working. It is in the dev/backlog branch, and will be merged in soon. Eventually I will look at how to create custom sox / ffmpeg so you can change parameters around.

robotastic added a commit that referenced this issue Jan 5, 2025
* Adds tags to the .M4A files

This should address #369

* needs to add quotes

* better title text

* Support for Boost 1.87

Addresses #988

* cleans up build messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants