Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PolygonZone] - allow per class counting #817

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

[PolygonZone] - allow per class counting #817

wants to merge 8 commits into from

Conversation

karanjakhar
Copy link
Contributor

Description

Resolves #791

Type of change

  • New feature (non-breaking change which adds functionality)

How has this change been tested, please provide a testcase or example of how you tested the change?

https://colab.research.google.com/drive/1RQqqMvQfyWv4fYg5vUVJfK_xt8lSQ5PQ?usp=sharing

@SkalskiP SkalskiP added enhancement New feature or request api:polygonzone PolygonZone API labels Jan 31, 2024
@SkalskiP
Copy link
Collaborator

Hi @karanjakhar 👋🏻 Thanks a lot for your interest in Supervision! I see you implemented the current class_in_count and class_out_count. In my task, I mainly meant total counts. What you create is also helpful and valuable.

Would you be willing to extend the logic and implement class_in_current_count, class_out_current_count, class_in_total_count, and class_out_total_count?

@karanjakhar
Copy link
Contributor Author

@SkalskiP Yes. I will add that also.

@SkalskiP
Copy link
Collaborator

Awesome! Let me know once you'll be ready for review.

@karanjakhar
Copy link
Contributor Author

Hi @SkalskiP , I have made the changes. Please review.

@karanjakhar
Copy link
Contributor Author

Hi @SkalskiP
I have added tests also for PolygonZone. Please review.

@karanjakhar
Copy link
Contributor Author

Hi @SkalskiP
Please review and let me know if something else need to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@karanjakhar karanjakhar

Labels
api:polygonzone PolygonZone API enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PolygonZone] - allow per class counting
2 participants
@karanjakhar @SkalskiP