Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #285 #289

Merged
merged 1 commit into from
Aug 16, 2023
Merged

fixes #285 #289

merged 1 commit into from
Aug 16, 2023

Conversation

rizavelioglu
Copy link
Contributor

Description

Fixes #285

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

See #285

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there, thank you for opening an PR ! 🙏🏻 The team was notified and they will get back to you asap.

@SkalskiP SkalskiP added the bug Something isn't working label Aug 15, 2023
@SkalskiP SkalskiP added this to the version: 0.14.0 milestone Aug 15, 2023
@SkalskiP
Copy link
Collaborator

@hardikdava could you use the notebook linked in this issue: #285 and test if the issue is solved and the overall behavior of as_coco and from_coco is preserved?

@SkalskiP SkalskiP added the version 0.14.0 Feature to be added in `0.14.0` release label Aug 15, 2023
@SkalskiP
Copy link
Collaborator

Hi, @rizavelioglu 👋🏻! I tested the changes. We are good. Merging.

@SkalskiP SkalskiP merged commit c2b9745 into roboflow:develop Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working version 0.14.0 Feature to be added in `0.14.0` release
Projects
Status: Current Release: Done
Development

Successfully merging this pull request may close these issues.

Wrong COCO format while exporting a sv.DetectionDataset using its as_coco method
3 participants