fix: ignore relative selector lists when resolving multiple selectors

[1000hz]

Description

fela-multiple-selectors-plugin currently naively splits selectors on ,, but this doesn't account for relative selector lists that may be within a pseudo-class. This results in invalid selectors being resolved.

This PR fixes that issue by making use of lookahead and lookbehind assertions when splitting to avoid matching within pseudo-class selector lists.

Example

:not(:hover, :focus) {}

currently resolves to :not(:hover and :focus), both of which are invalid.

With this PR, the selector remains whole as :not(:hover, :focus).

Packages

List all packages that have been changed.

• fela-plugin-multiple-selectors

Versioning

Patch

Checklist

Quality Assurance

You can also run pnpm run check to run all 4 commands at once.

• The code was formatted using Prettier (pnpm run format)
• The code has no linting errors (pnpm run lint)
• All tests are passing (pnpm run test)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

• Tests have been added/updated
• Documentation has been added/updated

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
fela	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 20, 2024 3:43pm