Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated IConfig interface #906

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Updated IConfig interface #906

merged 1 commit into from
Nov 16, 2022

Conversation

AvalonCV
Copy link
Contributor

Description

adds three missing options

  • optimizeCaching
  • styleNodeAttributes
  • propertyPriority

to the IConfig interface (#905).

Packages

  • fela

Checklist

Quality Assurance

You can also run pnpm run check to run all 4 commands at once.

  • The code was formatted using Prettier (pnpm run format)
  • The code has no linting errors (pnpm run lint)
  • All tests are passing (pnpm run test)

I tried to run pnpm run lint bit it gives me a myriad of problems and warnings :/
I followed https://github.com/robinweser/fela/blob/master/.github/CONTRIBUTING.md, am I something missing?

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated

@vercel
Copy link

vercel bot commented Jul 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
fela ✅ Ready (Inspect) Visit Preview Jul 14, 2022 at 9:32AM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants