Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add children prop to ProviderProps and ThemeProviderProps #902

Merged
merged 1 commit into from
May 3, 2022
Merged

fix: add children prop to ProviderProps and ThemeProviderProps #902

merged 1 commit into from
May 3, 2022

Conversation

firminochangani
Copy link
Contributor

Description

After I had updated fela and react-fela to the version 12.1.1, I started getting the following error, in a Nextjs-based project and in a CRA-based project, both using Typescript.

'RendererProvider' cannot be used as a JSX component.
  Its instance type 'RendererProvider' is not a valid JSX element.
    Type 'RendererProvider' is missing the following properties from type 'ElementClass': render, context, setState, forceUpdate, and 3 more.

Example

If required, add a code example or a link to a working example (repository).

Screenshot_2022-05-03_at_12_32_56
Screenshot_2022-05-03_at_12_33_05

Packages

List all packages that have been changed.

  • react-fela

Versioning

None / Patch / Minor / Major

Checklist

Quality Assurance

You can also run pnpm run check to run all 4 commands at once.

  • The code was formatted using Prettier (pnpm run format)
  • The code has no linting errors (pnpm run lint)
  • All tests are passing (pnpm run test)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated

@vercel
Copy link

vercel bot commented May 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
fela ✅ Ready (Inspect) Visit Preview May 3, 2022 at 11:49AM (UTC)

Copy link
Owner

@robinweser robinweser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! How did this even work for such a long time 😅
Thanks a lot!

@robinweser robinweser merged commit 041bbfd into robinweser:master May 3, 2022
@firatgh
Copy link

firatgh commented May 3, 2022

@robinweser Thanks for acting on it rather quickly.

@robinweser
Copy link
Owner

Will be released tomorrow 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants