Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fela-enforce-longhands: Handle vendor prefixes #900

Merged

Conversation

alizeait
Copy link
Contributor

Description

When using vendor prefixed properties or using fela-plugin-prefixer, properties that get a vendor prefix will be skipped from the priority list causing those ones to not have the specificity class selector added.

Packages

List all packages that have been changed.

  • fela-enforce-longhands

Versioning

Minor

Checklist

Quality Assurance

You can also run pnpm run check to run all 4 commands at once.

  • The code was formatted using Prettier (pnpm run format)
  • The code has no linting errors (pnpm run lint)
  • All tests are passing (pnpm run test)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated

@vercel
Copy link

vercel bot commented Apr 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/robinweser/fela/BrXZg1YQnoWR9kXFPaXVV4qMP98T
✅ Preview: https://fela-git-fork-alizeait-fela-enforce-longhands-1edd60-robinweser.vercel.app

@alizeait
Copy link
Contributor Author

alizeait commented May 2, 2022

Ping @robinweser

@robinweser
Copy link
Owner

Thanks @alizeait!
I've been out on a scouts camp, so not really able to merge anything.
Release coming soon :)

@robinweser robinweser merged commit 3a2b9c1 into robinweser:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants