Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update typescript definitions #892

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Conversation

jancama2
Copy link
Contributor

Description

Update fela-plugin-named-keys with function argument.
Add fela-plugin-expand-shorthand type.

Packages

List all packages that have been changed.

  • fela

Versioning

Patch

Checklist

Quality Assurance

You can also run yarn run check to run all 4 commands at once.

  • The code was formatted using Prettier (yarn run format)
  • The code has no linting errors (yarn run lint)
  • All tests are passing (yarn run test)
  • There are no flow-type errors (yarn run flow)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated
  • My changes have proper flow-types

Update `fela-plugin-named-keys` with function type.
Add `fela-plugin-expand-shorthand` type.
@vercel
Copy link

vercel bot commented Feb 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/robinweser/fela/2djMZmF2DXB9uG1w8MREtvuNMgJv
✅ Preview: https://fela-git-fork-jancama2-patch-1-robinweser.vercel.app

@robinweser
Copy link
Owner

Awesome, thanks for the PR! Especially everything TypeScript related is a blessing for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants