Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve istyle type #851

Merged
merged 11 commits into from
Jan 27, 2021
Merged

Conversation

hedwiggggg
Copy link
Contributor

Description

Refactor IStyle typings for better typescript support.

Example

See playgrounds at #850

Packages

List all packages that have been changed.

  • fela
  • fela-plugin-fallback-value
  • fela-plugin-typescript

Versioning

Patch

Checklist

Quality Assurance

You can also run yarn run check to run all 4 commands at once.

  • The code was formatted using Prettier (yarn run format)
  • The code has no linting errors (yarn run lint)
  • All tests are passing (yarn run test)
  • There are no flow-type errors (yarn run flow)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated
  • My changes have proper flow-types

@vercel
Copy link

vercel bot commented Jan 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/robinweser/fela/331xe9ldk
✅ Preview: https://fela-git-fork-feedbax-improve-istyle-type.robinweser.vercel.app

Silas Rosenkranz added 2 commits January 21, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants