Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-fela] Fix useFela hook types to support composition #846

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

hedwiggggg
Copy link
Contributor

Description

#845

Packages

List all packages that have been changed.

  • react-fela

Versioning

Patch

Checklist

Quality Assurance

You can also run yarn run check to run all 4 commands at once.

  • The code was formatted using Prettier (yarn run format)
  • The code has no linting errors (yarn run lint)
  • All tests are passing (yarn run test)
  • There are no flow-type errors (yarn run flow)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated
  • My changes have proper flow-types

@vercel
Copy link

vercel bot commented Jan 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/robinweser/fela/prj1o8vzo
✅ Preview: https://fela-git-fork-feedbax-fix-react-fela-types.robinweser.vercel.app

@hedwiggggg hedwiggggg changed the title Fix useFela hook types to support composition [react-fela] Fix useFela hook types to support composition Jan 6, 2021
@robinweser robinweser merged commit 7ccd60b into robinweser:master Jan 19, 2021
@robinweser
Copy link
Owner

Amazing, thank you :)

@hedwiggggg hedwiggggg deleted the fix-react-fela-types branch January 19, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants