Add argument type #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev-dfm
approved these changes
Mar 29, 2023
| bottom: BorderSide(color: Colors.grey.shade400), | ||
| ), | ||
| ), | ||
| width: double.infinity, |
There was a problem hiding this comment.
The infinite width can be removed
There was a problem hiding this comment.
No, that would result in a line that is as wide as the title instead of being as wide as the configuration bar.
robiness
reviewed
Mar 29, 2023
| ); | ||
|
|
||
| @override | ||
| List<FieldConfigurator> get fieldConfigurators { |
There was a problem hiding this comment.
instead of marking every FieldConfigurator i would prefer to have two lists here instead. Like widgetFieldConfigurators and stageFieldConfiguators.
|
@danielmolnar I refactored the configuration list a bit, i hope thats fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to separate between configurators that affect the actual widget on the stage and configurators that change properties "around" such widget (e.g. widget count, if the widget should be placed on the stage as a list).
Bildschirmaufnahme.2023-03-29.um.15.01.19.mov