Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust appearance #13

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Adjust appearance #13

merged 5 commits into from
Jun 6, 2023

Conversation

robiness
Copy link
Owner

@robiness robiness commented Jun 6, 2023

This tries to achieve a bit more coherent UI for the configurators. The main purpose was to make the input fields a bit thinner so they don't take to much space. Previously the default material height for mobile was used.

Every input field like for string, double, int etc. use the FieldConfiguratorWidget now so we only have one point to improve this further or change it completely if we want to.

As a bonus this also fixes a bug on double and int configurators not being updated when null was pressed.

Before After
image image

@robiness robiness requested a review from danielmolnar June 6, 2023 15:04
Copy link
Collaborator

@danielmolnar danielmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robiness robiness merged commit d475d49 into main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants