Skip to content

Commit

Permalink
Update remaining references to Jira to GH (apache#21834)
Browse files Browse the repository at this point in the history
* Update remaining references to Jira to GH

* Switch to links

* Spotless apply

* Link format

* Undo vscode changes

* Remove one more extraneous vscode reference

* Fix broken links

* Fix broken links

* Fix spacing
  • Loading branch information
damccorm authored Jun 16, 2022
1 parent b774ff5 commit 1dff59b
Show file tree
Hide file tree
Showing 30 changed files with 58 additions and 54 deletions.
2 changes: 1 addition & 1 deletion .test-infra/jenkins/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ plugins {
applyGroovyNature()
applyPythonNature()

// TODO(BEAM-9980): Don't hardcode this version, take the value provided by Python nature.
// TODO(https://github.com/apache/beam/issues/20209): Don't hardcode this version, take the value provided by Python nature.
pythonVersion = '3.8'

task generateMetricsReport {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import static LoadTestsBuilder.DOCKER_BEAM_SDK_IMAGE

String now = new Date().format("MMddHHmmss", TimeZone.getTimeZone('UTC'))

// TODO(BEAM-10852): Skipping some cases because they are too slow.
// TODO(https://github.com/apache/beam/issues/20402): Skipping some cases because they are too slow.
def TESTS_TO_SKIP = [
'load-tests-python-flink-streaming-combine-1',
]
Expand Down
2 changes: 1 addition & 1 deletion .test-infra/jenkins/job_LoadTests_Combine_Python.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def loadTestConfigurations = { datasetName, mode ->

def addStreamingOptions(test){
test.pipelineOptions << [streaming: null,
// TODO(BEAM-11779) remove shuffle_mode=appliance with runner v2 once issue is resolved.
// TODO(https://github.com/apache/beam/issues/20806) remove shuffle_mode=appliance with runner v2 once issue is resolved.
experiments: "use_runner_v2, shuffle_mode=appliance"
]
}
Expand Down
2 changes: 1 addition & 1 deletion .test-infra/jenkins/job_LoadTests_GBK_Flink_Go.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import static LoadTestsBuilder.DOCKER_CONTAINER_REGISTRY

String now = new Date().format('MMddHHmmss', TimeZone.getTimeZone('UTC'))

// TODO(BEAM-9761): Skipping some cases because they are too slow or have memory errors.
// TODO(https://github.com/apache/beam/issues/20146): Skipping some cases because they are too slow or have memory errors.
def TESTS_TO_SKIP = [
'load-tests-go-flink-batch-gbk-7',
]
Expand Down
2 changes: 1 addition & 1 deletion .test-infra/jenkins/job_LoadTests_GBK_Flink_Python.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -168,4 +168,4 @@ PhraseTriggeringPostCommitBuilder.postCommitJob(
loadTest(delegate, CommonTestProperties.TriggeringContext.PR)
}

// TODO(BEAM-9761) Re-enable auto builds after these tests pass.
// TODO(https://github.com/apache/beam/issues/20146) Re-enable auto builds after these tests pass.
4 changes: 2 additions & 2 deletions .test-infra/jenkins/job_LoadTests_GBK_Python.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import InfluxDBCredentialsHelper

def now = new Date().format("MMddHHmmss", TimeZone.getTimeZone('UTC'))

// TODO(BEAM-10774): Skipping some cases because they are too slow.
// TODO(https://github.com/apache/beam/issues/20403): Skipping some cases because they are too slow.
def TESTS_TO_SKIP = [
'load-tests-python-dataflow-streaming-gbk-1',
'load-tests-python-dataflow-streaming-gbk-2',
Expand Down Expand Up @@ -156,7 +156,7 @@ def addStreamingOptions(test) {
// Use the new Dataflow runner, which offers improved efficiency of Dataflow jobs.
// See https://cloud.google.com/dataflow/docs/guides/deploying-a-pipeline#dataflow-runner-v2
// for more details.
// TODO(BEAM-11779) remove shuffle_mode=appliance with runner v2 once issue is resolved.
// TODO(https://github.com/apache/beam/issues/20806) remove shuffle_mode=appliance with runner v2 once issue is resolved.
experiments: 'use_runner_v2, shuffle_mode=appliance',
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def addStreamingOptions(test) {
// Use the new Dataflow runner, which offers improved efficiency of Dataflow jobs.
// See https://cloud.google.com/dataflow/docs/guides/deploying-a-pipeline#dataflow-runner-v2
// for more details.
// TODO(BEAM-11779) remove shuffle_mode=appliance with runner v2 once issue is resolved.
// TODO(https://github.com/apache/beam/issues/20806) remove shuffle_mode=appliance with runner v2 once issue is resolved.
experiments: 'use_runner_v2, shuffle_mode=appliance',
]
}
Expand Down
2 changes: 1 addition & 1 deletion .test-infra/jenkins/job_LoadTests_ParDo_Python.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def addStreamingOptions(test) {
// Use the new Dataflow runner, which offers improved efficiency of Dataflow jobs.
// See https://cloud.google.com/dataflow/docs/guides/deploying-a-pipeline#dataflow-runner-v2
// for more details.
// TODO(BEAM-11779) remove shuffle_mode=appliance with runner v2 once issue is resolved.
// TODO(https://github.com/apache/beam/issues/20806) remove shuffle_mode=appliance with runner v2 once issue is resolved.
experiments: 'use_runner_v2, shuffle_mode=appliance',
]
}
Expand Down
2 changes: 1 addition & 1 deletion .test-infra/jenkins/job_LoadTests_SideInput_Python.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def fromTemplate = { mode, name, id, datasetName, testSpecificOptions ->
influx_measurement : "python_${mode}_sideinput_${id}",
num_workers : 10,
autoscaling_algorithm: 'NONE',
// TODO(BEAM-11779) remove shuffle_mode=appliance with runner v2 once issue is resolved.
// TODO(https://github.com/apache/beam/issues/20806) remove shuffle_mode=appliance with runner v2 once issue is resolved.
experiments : 'use_runner_v2, shuffle_mode=appliance',
] << testSpecificOptions
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -152,4 +152,4 @@ PhraseTriggeringPostCommitBuilder.postCommitJob(
loadTest(delegate, CommonTestProperties.TriggeringContext.PR)
}

// TODO(BEAM-9761) Re-enable auto builds after these tests pass.
// TODO(https://github.com/apache/beam/issues/20146) Re-enable auto builds after these tests pass.
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ jobs.findAll {
'beam_PerformanceTests_TextIOIT_HDFS',
'beam_PerformanceTests_Compressed_TextIOIT_HDFS',
'beam_PerformanceTests_ManyFiles_TextIOIT_HDFS',
// TODO(BEAM-3945) TFRecord performance test is failing only when running on hdfs.
// TODO(https://github.com/apache/beam/issues/18796) TFRecord performance test is failing only when running on hdfs.
// We need to fix this before enabling this job on jenkins.
//'beam_PerformanceTests_TFRecordIOIT_HDFS',
'beam_PerformanceTests_AvroIOIT_HDFS',
Expand Down
6 changes: 3 additions & 3 deletions .test-infra/jenkins/job_PerformanceTests_KafkaIO_IT.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ String jobName = "beam_PerformanceTests_Kafka_IO"

job(jobName) {
common.setTopLevelMainJobProperties(delegate)
// TODO(BEAM-9482): Re-enable once fixed.
// TODO(https://github.com/apache/beam/issues/20333): Re-enable once fixed.
// common.setAutoJob(delegate, 'H H/6 * * *')
// common.enablePhraseTriggeringFromPullRequest(
// delegate,
Expand Down Expand Up @@ -75,7 +75,7 @@ job(jobName) {
kafkaTopic : 'beam-runnerv2',
bigQueryTable : 'kafkaioit_results_sdf_wrapper',
influxMeasurement : 'kafkaioit_results_sdf_wrapper',
// TODO(BEAM-11779) remove shuffle_mode=appliance with runner v2 once issue is resolved.
// TODO(https://github.com/apache/beam/issues/20806) remove shuffle_mode=appliance with runner v2 once issue is resolved.
experiments : 'use_runner_v2,shuffle_mode=appliance,use_unified_worker',
]

Expand All @@ -90,7 +90,7 @@ job(jobName) {
kafkaTopic : 'beam-sdf',
bigQueryTable : 'kafkaioit_results_runner_v2',
influxMeasurement : 'kafkaioit_results_runner_v2',
// TODO(BEAM-11779) remove shuffle_mode=appliance with runner v2 once issue is resolved.
// TODO(https://github.com/apache/beam/issues/20806) remove shuffle_mode=appliance with runner v2 once issue is resolved.
experiments : 'use_runner_v2,shuffle_mode=appliance,use_unified_worker',
]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ PostcommitJobBuilder.postCommitJob('beam_PostCommit_Java_PVR_Flink_Streaming',
tasks(":runners:flink:${CommonTestProperties.getFlinkVersion()}:job-server:validatesPortableRunnerStreaming")
commonJobProperties.setGradleSwitches(delegate)
}
// TODO(BEAM-10940): Enable this test suite once we have support.
// TODO(https://github.com/apache/beam/issues/20668): Enable this test suite once we have support.
//gradle {
// rootBuildScriptDir(commonJobProperties.checkoutDir)
// tasks(":runners:flink:${CommonTestProperties.getFlinkVersion()}:job-server:validatesPortableRunnerStreamingCheckpoint")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ PhraseTriggeringPostCommitBuilder.postCommitJob(
chicagoTaxiJob(delegate)
}

// TODO(BEAM-9154): Chicago Taxi Example doesn't work in Python 3.
// TODO(https://github.com/apache/beam/issues/19973): Chicago Taxi Example doesn't work in Python 3.
// Uncomment below once it is fixed.
//
// CronJobBuilder.cronJob(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ PhraseTriggeringPostCommitBuilder.postCommitJob(
chicagoTaxiJob(delegate)
}

// TODO(BEAM-9154): Chicago Taxi Example doesn't work in Python 3.
// TODO(https://github.com/apache/beam/issues/19973): Chicago Taxi Example doesn't work in Python 3.
// Uncomment below once it is fixed.
//
// CronJobBuilder.cronJob(
Expand Down
2 changes: 1 addition & 1 deletion .test-infra/jenkins/metrics_report/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
; See the License for the specific language governing permissions and
; limitations under the License.
;
; TODO(BEAM-9980): Don't hardcode Py3.8 version.
; TODO(https://github.com/apache/beam/issues/20209): Don't hardcode Py3.8 version.
[tox]
skipsdist = True
envlist = py38-test,py38-generate-report
Expand Down
6 changes: 3 additions & 3 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ tasks.register("pythonDockerBuildPreCommit") {
}

tasks.register("pythonLintPreCommit") {
// TODO(BEAM-9980): Find a better way to specify lint and formatter tasks without hardcoding py version.
// TODO(https://github.com/apache/beam/issues/20209): Find a better way to specify lint and formatter tasks without hardcoding py version.
dependsOn(":sdks:python:test-suites:tox:py37:lint")
}

Expand Down Expand Up @@ -379,14 +379,14 @@ tasks.register("runBeamDependencyCheck") {
}

tasks.register("whitespacePreCommit") {
// TODO(BEAM-9980): Find a better way to specify the tasks without hardcoding py version.
// TODO(https://github.com/apache/beam/issues/20209): Find a better way to specify the tasks without hardcoding py version.
dependsOn(":sdks:python:test-suites:tox:py38:archiveFilesToLint")
dependsOn(":sdks:python:test-suites:tox:py38:unpackFilesToLint")
dependsOn(":sdks:python:test-suites:tox:py38:whitespacelint")
}

tasks.register("typescriptPreCommit") {
// TODO(BEAM-9980): Find a better way to specify the tasks without hardcoding py version.
// TODO(https://github.com/apache/beam/issues/20209): Find a better way to specify the tasks without hardcoding py version.
dependsOn(":sdks:python:test-suites:tox:py38:eslint")
dependsOn(":sdks:python:test-suites:tox:py38:jest")
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1169,7 +1169,7 @@ class BeamModulePlugin implements Plugin<Project> {
options.errorprone.disableWarningsInGeneratedCode = true
options.errorprone.excludedPaths = '(.*/)?(build/generated-src|build/generated.*avro-java|build/generated)/.*'

// TODO(BEAM-11936): Enable errorprone checks
// TODO(https://github.com/apache/beam/issues/20955): Enable errorprone checks
options.errorprone.errorproneArgs.add("-Xep:AutoValueImmutableFields:OFF")
options.errorprone.errorproneArgs.add("-Xep:AutoValueSubclassLeaked:OFF")
options.errorprone.errorproneArgs.add("-Xep:BadImport:OFF")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@
*/
@SuppressWarnings({
"nullness", // TODO(https://github.com/apache/beam/issues/20497)
"unused" // TODO(BEAM-13271): Remove when new version of errorprone is released (2.11.0)
// TODO(https://github.com/apache/beam/issues/21230): Remove when new version of
// errorprone is released (2.11.0)
"unused"
})
public class StatefulTeamScore extends LeaderBoard {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@
@SuppressWarnings({
"rawtypes", // TODO(https://github.com/apache/beam/issues/20447)
"nullness", // TODO(https://github.com/apache/beam/issues/20497)
"unused" // TODO(BEAM-13271): Remove when new version of errorprone is released (2.11.0)
// TODO(https://github.com/apache/beam/issues/21230): Remove when new version of
// errorprone is released (2.11.0)
"unused"
})
public class Snippets {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@
"\n",
"> *Known issues:*\n",
">\n",
"> * [[BEAM-7340]](https://github.com/apache/beam/issues/19394)\n",
"> * [[Issue 19394]](https://github.com/apache/beam/issues/19394)\n",
"> `DoFn.teardown()` metrics are lost."
]
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ message StandardUserStateTypes {
// StateKey.MultimapKeysUserState or StateKey.MultimapUserState.
MULTIMAP = 1 [(beam_urn) = "beam:user_state:multimap:v1"];

// TODO(BEAM-10650): Add protocol to support OrderedListState
// TODO(https://github.com/apache/beam/issues/20486): Add protocol to support OrderedListState
}
}

Expand Down Expand Up @@ -1024,11 +1024,11 @@ message StandardCoders {
//
// Schema types are mapped to coders as follows:
// AtomicType:
// BYTE: not yet a standard coder (BEAM-7996)
// INT16: not yet a standard coder (BEAM-7996)
// BYTE: not yet a standard coder (https://github.com/apache/beam/issues/19815)
// INT16: not yet a standard coder (https://github.com/apache/beam/issues/19815)
// INT32: beam:coder:varint:v1
// INT64: beam:coder:varint:v1
// FLOAT: not yet a standard coder (BEAM-7996)
// FLOAT: not yet a standard coder (https://github.com/apache/beam/issues/19815)
// DOUBLE: beam:coder:double:v1
// STRING: beam:coder:string_utf8:v1
// BOOLEAN: beam:coder:bool:v1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ message MonitoringInfoSpecs {
// which does not fit into a typical metric format. See MonitoringTableData
// for more details.
//
// TODO(BEAM-9617): Support monitored state.
// TODO(https://github.com/apache/beam/issues/20122): Support monitored state.
//
// USER_MONITORING_TABLE = XX [(monitoring_info_spec) = {
// urn: "beam:metric:user:v1",
Expand Down Expand Up @@ -561,7 +561,7 @@ message MonitoringInfoTypeUrns {
// which does not fit into a typical metric format. See MonitoringTableData
// for more details.
//
// TODO(BEAM-9617): Support monitored state.
// TODO(https://github.com/apache/beam/issues/20122): Support monitored state.
//
// Encoding: MonitoringTableData proto encoded as bytes
// MONITORING_TABLE_TYPE = XX [(org.apache.beam.model.pipeline.v1.beam_urn) =
Expand All @@ -587,7 +587,7 @@ message MonitoringInfoTypeUrns {
// to aggregate these metrics in custom ways. Engines can use custom aggregation
// functions for specific URNs by inspecting the column values.
//
// TODO(BEAM-9617): Support monitored state.
// TODO(https://github.com/apache/beam/issues/20122): Support monitored state.
//
// message MonitoringTableData {
// message MonitoringColumnValue {
Expand Down
2 changes: 1 addition & 1 deletion release/src/main/scripts/build_release_candidate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ if [[ $confirmation = "y" ]]; then
git clone --branch "${RC_TAG}" --depth 1 ${GIT_REPO_URL}
cd ${BEAM_ROOT_DIR}
RELEASE_COMMIT=$(git rev-list -n 1 "tags/${RC_TAG}")
# TODO(BEAM-9980): Don't hardcode py version in this file.
# TODO(https://github.com/apache/beam/issues/20209): Don't hardcode py version in this file.
cd sdks/python && pip install -r build-requirements.txt && tox -e py38-docs
GENERATED_PYDOC=~/${LOCAL_WEBSITE_UPDATE_DIR}/${LOCAL_PYTHON_DOC}/${BEAM_ROOT_DIR}/sdks/python/target/docs/_build
rm -rf ${GENERATED_PYDOC}/.doctrees
Expand Down
4 changes: 2 additions & 2 deletions release/src/main/scripts/run_rc_validation.sh
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ echo "All environment and workflow configurations from RC_VALIDATE_CONFIGS:"
for i in "${RC_VALIDATE_CONFIGS[@]}"; do
echo "$i = ${!i}"
done
echo "TODO(BEAM-13054): parts of this script launch background processes with gnome-terminal,"
echo "TODO(https://github.com/apache/beam/issues/21237): parts of this script launch background processes with gnome-terminal,"
echo "It may not work well over ssh or within a tmux session. Using 'ssh -Y' may help."
echo "[Confirmation Required] Would you like to proceed with current settings? [y|N]"
read confirmation
Expand Down Expand Up @@ -229,7 +229,7 @@ else
echo "* Skipping Python Quickstart and MobileGame. Hub is required."
fi

# TODO(BEAM-13220) Run the remaining tests on Jenkins.
# TODO(https://github.com/apache/beam/issues/21193) Run the remaining tests on Jenkins.
echo ""
echo "====================Starting Python Leaderboard & GameStates Validations==============="
if [[ ("$python_leaderboard_direct" = true \
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/pr-bot/processNewPrs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ async function processPull(
return;
}

// TODO(BEAM-13925) - also check if the author is a committer, if they are don't auto-assign a committer
// TODO(https://github.com/apache/beam/issues/21417) - also check if the author is a committer, if they are don't auto-assign a committer
for (const approver of approvers) {
const labelOfReviewer = prState.getLabelForReviewer(approver);
if (labelOfReviewer) {
Expand Down
6 changes: 3 additions & 3 deletions sdks/typescript/src/apache_beam/proto/beam_runner_api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1564,11 +1564,11 @@ export enum StandardCoders_Enum {
*
* Schema types are mapped to coders as follows:
* AtomicType:
* BYTE: not yet a standard coder (BEAM-7996)
* INT16: not yet a standard coder (BEAM-7996)
* BYTE: not yet a standard coder (https://github.com/apache/beam/issues/19815)
* INT16: not yet a standard coder (https://github.com/apache/beam/issues/19815)
* INT32: beam:coder:varint:v1
* INT64: beam:coder:varint:v1
* FLOAT: not yet a standard coder (BEAM-7996)
* FLOAT: not yet a standard coder (https://github.com/apache/beam/issues/19815)
* DOUBLE: beam:coder:double:v1
* STRING: beam:coder:string_utf8:v1
* BOOLEAN: beam:coder:bool:v1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Examples:

Beam DataFrame operations are deferred, but the schemas of the resulting DataFrames are not, meaning that result columns must be computable without access to the data. Some DataFrame operations can’t support this usage, so they can’t be implemented. These operations raise a [WontImplementError](https://beam.apache.org/releases/pydoc/{{< param release_latest >}}/apache_beam.dataframe.frame_base.html#apache_beam.dataframe.frame_base.WontImplementError).

<!-- TODO(BEAM-12169): Document the use of categorical columns as a workaround -->
<!-- TODO(https://github.com/apache/beam/issues/20958): Document the use of categorical columns as a workaround -->
Currently there’s no workaround for this issue. But in the future, Beam Dataframe may support non-deferred column operations on categorical columns. This work is being tracked in [Issue 20958](https://github.com/apache/beam/issues/20958).

### Operations that produce non-deferred values or plots
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,5 +212,5 @@ with beam.Pipeline() as p:
{{< /highlight >}}

{{< highlight java >}}
// Getting predictions is not yet available for Java. [BEAM-9501]
// Getting predictions is not yet available for Java. [https://github.com/apache/beam/issues/20001]
{{< /highlight >}}
Loading

0 comments on commit 1dff59b

Please sign in to comment.