final pass

.github/workflows/main.yml

@@ -1,16 +1,22 @@
-# For this script to run you must set some secrets:
-#
-# MAIL_CONNECTION
-#   ex: smtp://user:password@server:port
-# TO
-#   ex: [email protected]
-# FROM
-#   ex: Luke Skywalker <[email protected]>
-# 
-# To set these, you can use gh from the terminal:
-#   gh secret set MAIL_CONNECTION --body "smtp://foo:[email protected]:465" -R "robertmeta/emacspeak"
-#   gh secret set TO --body "[email protected]" -R "robertmeta/emacspeak"
-#   gh secret set FROM --body "Luke Skywalker <[email protected]>" -R "robertmeta/emacspeak"
+# For this script to run you must set some secret values in github.
+# The below use the `gh` command line utility to set them.
+
+# Notes:
+# These will default to the current repo if you don't pass -R "owner/repo"
+
+# Required:
+# 1. gh secret set TO -b "[email protected]" 
+# 2. gh secret set FROM -b "Luke Skywalker <[email protected]>" 
+# 3. gh secret set SMTP_HOST -b "smtp.fastmail.com" 
+# 4. gh secret set SMTP_USERNAME -b "[email protected]" 
+# 5. gh secret set SMTP_PASSWORD -b "secretpassword" 
+
+# Optional:
+# A. gh secret set SMTP_PORT -b "465" - defaults to 465
+# B. gh secret set SMTP_SECURE -b "true" - defaults to true
+
+# There are more settings you can find at:
+#   https://github.com/marketplace/actions/send-email
 
 on:
   issues:
@@ -24,13 +30,13 @@ jobs:
         uses: dawidd6/action-send-mail@v3
         with:
           server_address: ${{secrets.SMTP_HOST}}
-          server_port: ${{secrets.SMTP_PORT}}
-          secure: true
+          server_port: ${{secrets.SMTP_PORT || '465'}}
+          secure: ${{secrets.SMTP_SECURE || 'true'}}
           username: ${{secrets.SMTP_USERNAME}}
           password: ${{secrets.SMTP_PASSWORD}}
           convert_markdown: false
-          nodemailerlog: true
-          nodemailerdebug: true
+          nodemailerlog: false
+          nodemailerdebug: false
 
           to: ${{ secrets.TO }}
           from: ${{ secrets.FROM }}
@@ -46,7 +52,4 @@ jobs:
 
             Updated By: @${{ github.event.sender.login }}
 
-            Issue URL: ${{ github.event.issue.html_url }}
-
-            Extra Details: 
-            ${{ toJson(github.event) }}
+            Issue URL: ${{ github.event.issue.html_url }}