Skip to content

Commit

Permalink
RMM shouldn't install thrust
Browse files Browse the repository at this point in the history
When we merged rapidsai#854 we enabled
the installation of Thrust as part of RMM install. This causes
downstream issues as projects like cuDF want to use a patched
version to improve compile times.

Since RMM is header only we don't need to ensure our consumers
use the same Thrust version, so we can skip installing it.
  • Loading branch information
robertmaynard committed Sep 9, 2021
1 parent fe88c50 commit 8d5acd5
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions cmake/thirdparty/get_thrust.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,14 @@ function(find_and_configure_thrust)

include(${rapids-cmake-dir}/cpm/thrust.cmake)
rapids_cpm_thrust(
NAMESPACE rmm
BUILD_EXPORT_SET rmm-exports
INSTALL_EXPORT_SET rmm-exports)
NAMESPACE rmm)

# We don't list the export set information in rapids_cpm_thrust
# as we don't want to install Thrust as part of rmm install process.
# Doing so would stop consumers such as cudf from using patched
# versions, which they require for improved build times.
rapids_export_package(BUILD Thrust rmm-exports)
rapids_export_package(INSTALL Thrust rmm-exports)

endfunction()

Expand Down

0 comments on commit 8d5acd5

Please sign in to comment.