Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check whether _map is assigned to avoid errors on often redraw from scratch #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

utilmind
Copy link

This commit fixes the issue with attempt to draw points on uninitialized map.

Reproduce on https://wio2.utilmind.com/demo/

  1. Go to the page by link above and open browser console to see errors.
  2. Wait until map is loaded.
  3. Turn on "Weather" layer, which is based on glify.points().
    image
  4. Drag slider to switch weather frames too fast and too often.
    image

This fix only inserts validation whether _map is not empty to line # 168. (And the rest of changes are just shift due to formatting).

@utilmind utilmind changed the title fix: check _map is assigned to avoid errors on often redraw from scratch fix: check wether _map is assigned to avoid errors on often redraw from scratch Nov 29, 2024
@utilmind utilmind changed the title fix: check wether _map is assigned to avoid errors on often redraw from scratch fix: check whether _map is assigned to avoid errors on often redraw from scratch Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant