fix: missing flag from regex literal in corner case #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
changed the title
In the specific corner case where a regex contains a flag but is not followed by any symbols, the ast.RegExpLiteral.Literal value would drop (part of) that flag. This happens because the p.next() call during the parsing of the flag wouldn't actually advance the p.chrOffset, and thus endOffset would be erroneously adjusted. The fix is just to use the current p.chrOffset and then call p.next() afterwards.
|
@stevenh , I removed the erroneous import, the linter checks should pass now. |
stevenh
approved these changes
Jul 9, 2024
|
Thanks for the PR @psve 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the specific corner case where a regex contains a flag but is not followed by any symbols, the
ast.RegExpLiteral.Literalvalue would drop (part of) that flag.This happens because the
p.next()call during the parsing of the flag wouldn't actually advance thep.chrOffset, and thusendOffsetwould be erroneously adjusted.The fix is just to use the current
p.chrOffsetand then callp.next()afterwards.