Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: starting positions of for and for-in statements #503

Merged
merged 2 commits into from
Jul 18, 2023
Merged

fix: starting positions of for and for-in statements #503

merged 2 commits into from
Jul 18, 2023

Conversation

tyamagu2
Copy link
Contributor

Currently, the parser does not set their starting positions.

@tyamagu2
fix: starting positions of for and for-in statements
dc6c436 
Fix Idx0 of ForStatement and ForInStatement to point to the right place. They were previously not set.
stevenh
stevenh requested changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, two small improvements suggested so the test really confirms things are working.

parser/parser_test.go Outdated Show resolved Hide resolved
parser/parser_test.go Outdated Show resolved Hide resolved
@tyamagu2 tyamagu2 requested a review from stevenh July 18, 2023 09:21
@stevenh stevenh merged commit 0357209 into robertkrimen:master Jul 18, 2023
@stevenh
Copy link
Collaborator

stevenh commented Jul 18, 2023

Thanks @tyamagu2 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenh stevenh stevenh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyamagu2 @stevenh