Apply fixes from -Wclippy::pedantic

[chris-ha458]

I just used cargo clippy -- -Wclippy::pedantic to take a look into some potential fixes.

Some are straightforward and obvious, but some are more opinionated.
Let me know what you think!

[robertknight]

Hello - Most of the changes here are reasonable, although there is a reason clippy calls them pedantic and I wouldn't make that the default lint setting in this repository. The one change I wouldn't apply is the for-loop => fold (which incidentally, shows that a test is missing).

[robertknight]

I slightly prefer to_vec here because it makes the type more obvious.

[chris-ha458]

Looking into the code, obstacles is already made into a vec above
line 57 let mut obstacles = obstacles.to_vec();
Since is not consumed elsewhere later I think we can just use the shorthand initialization without .clone() or to_vec()

it would look like this

queue.push(Partition {
                score: score(boundary),
                boundary,
                obstacles,
            });

do you still prefer the original over this?

[robertknight]

You're right. The clone looks redundant. This could be made clearer by moving initialization of it inside the !boundary.is_empty() check.

[robertknight]

This is OK, although if new lines were added to the happy path, I'd probably want to revert back to the early-exit.

[chris-ha458]

if I understand correctly, the two versions of the code operate identically and the
if let Some vs let - else construction merely moves the main body vs exception placements around. This arguably makes it clearer what this part of the code intends to do vs what it does when it fails.

Usually let else is used when there are a lot of following code, where the if let Some pattern will introduce braces and tab drift.
Of course, if we assume both operate the same it becomes a matter of choice, and the opinion of the main maintainer/developer matters more IMO

If i inadvertently introduced any change in behavior I think this should also revert back to the original.

[robertknight]

Usually let else is used when there are a lot of following code, where the if let Some pattern will introduce braces and tab drift.

Yes, this is one reason. The other is to logically have early-exit checks at the top of the function and then have the main body concentrate on the happy path. This also matters mainly when there are multiple early-exits. With the current body both are easy to read, and I would be fine with either.

[robertknight]

Thanks for the contribution.

[robertknight]

Usually let else is used when there are a lot of following code, where the if let Some pattern will introduce braces and tab drift.

Yes, this is one reason. The other is to logically have early-exit checks at the top of the function and then have the main body concentrate on the happy path. This also matters mainly when there are multiple early-exits. With the current body both are easy to read, and I would be fine with either.