Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clipboard support to CLI #128

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Exotik850
Copy link

Integrates the clipboard-rs crate to enable direct clipboard image import functionality as an alternative input method alongside existing file path support. Implementation includes proper error handling, platform-specific clipboard access, and graceful feedback whenever both clipboard and file inputs are in the arguments. This enhancement significantly improves user experience by eliminating the need for manual file path input or image saving, streamlining the workflow for users who frequently process screenshots or web images.

@robertknight
Copy link
Owner

Hello. Thanks for the contribution. This seems like a useful feature. Since it does add significant new dependencies which may not be needed or available on some systems I would like it to be behind a crate feature (clipboard). Also I would prefer to use arboard as the dependency to read the clipboard. I can't see anything wrong with clipboard-rs from skimming the code, but since there is a lot of platform-specific / unsafe code in there, I'd prefer to have something with as many eyeballs on it as possible.

@Exotik850
Copy link
Author

I like arboard much more as a dependency as well, I'd also like to implement outputting to the clipboard as well in the future but that may be outside the scope of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants