Add test case for allowed_chars option, better error handling for alphabet-model mismatch
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recognition test uses a fake model with only 64 columns in the output. Modify the alphabet accordingly.
…el output If a custom alphabet is specified with a size that does not match the model output shape, make recognition fail with an error that is easy to understand. This situation means that the wrong alphabet has been used, which means that the recognition outputs might either be completely wrong or have "?" chars substituted for out-of-bounds character indices.
The inputs don't have to be one-hot vectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test case for the
allowed_charsoption that was added in #119. In the process it was necessary to: