-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cli can take custom alphabet as args #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch. I requested some adjustment to the wording to make it clear that the alphabet has to match the model. The user can't just use whatever alphabet they like.
In future I think it will make sense to have a way to embed the alphabet in the model file, or provide it as part of a configuration file that is shipped alongside the model. In the interim, adding a CLI argument is useful.
…alphabet Co-authored-by: Robert Knight <[email protected]>
Co-authored-by: Robert Knight <[email protected]>
I agree that embedding the alphabet in the model file would be a good feature. |
That's not a problem. As a maintainer, I can also do this when merging a PR using the "Squash and merge" option. For future reference, you can use |
(Maintainer's note - this is a counterpart to #100 for the CLI tool)