Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ocrs_models.datasets #11

Merged
merged 5 commits into from
Feb 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ jobs:
run: |
poetry install
poetry run pip install torch torchvision
- name: Check formatting and types
- name: Lint, format and typecheck
run: |
poetry run black --check .
poetry run mypy ocrs_models
make qa
6 changes: 4 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Model checkpoints
*.pt

datasets/
wandb/
__pycache__/

/datasets
/wandb
17 changes: 16 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
qa:
.PHONY: qa
qa: checkformat lint typecheck

.PHONY: checkformat
checkformat:
poetry run black --check .

.PHONY: format
format:
poetry run black ocrs_models

.PHONY: lint
lint:
poetry run ruff ocrs_models

.PHONY: typecheck
typecheck:
poetry run mypy ocrs_models
Loading
Loading