Skip to content

Commit

Permalink
Add support for php 8.2 #28
Browse files Browse the repository at this point in the history
  • Loading branch information
robertfausk committed Sep 17, 2022
1 parent 4b07ace commit e85836e
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
php: [ '7.2', '7.3', '7.4', '8.0', '8.1' ]
php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2' ]
fail-fast: false
env:
MATRIX_PHP: ${{ matrix.php }}
Expand Down
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
vx.x.x / 2022-xx-xx
===================

Features:
* Add support for ```PHP 8.2``` #28

Misc:

* Rename branch ```master``` to ```main``` cause black lives matter. #26 #27

v1.1.0 / 2022-07-25
===================

Expand Down
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ COPY --from=composer /usr/bin/composer /usr/bin/composer
ENV COMPOSER_ALLOW_SUPERUSER 1
ENV COMPOSER_HOME /home/docker/.composer
# contains dev-mode packages
RUN composer global config --no-plugins allow-plugins.pyrech/composer-changelogs true
RUN composer global require "pyrech/composer-changelogs:^1.7" --prefer-dist --no-progress --classmap-authoritative

##############################################################
Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ protected static $defaultOptions = [
'readinessPath' => '',
'browser' => PantherTestCase::CHROME,
];
$kernelOptions = [];
$kernelOptions = []; # unused cause we do not extend class KernelTestCase
$managerOptions = [];

$mink = new Mink(array(
Expand All @@ -70,19 +70,19 @@ and give [robertfausk/behat-panther-extension](https://github.com/robertfausk/be

## How to contribute?

Start docker-compose with php web driver
Start docker-compose with php web driver by using one of the prepared docker setups with php7.2, php7.3, php7.4, php8.0, php8.1 or php8.2.

docker-compose up php8.1
docker-compose up php8.2

Run phpunit tests

docker-compose exec php8.1 vendor/bin/phpunit
docker-compose exec php8.2 vendor/bin/phpunit

If you run into issues of type ```session not created: This version of ChromeDriver only supports Chrome version 79```
then it is because of mismatched versions between installed chrome driver and chromium.
Best way to bypass this problem is to update them to their newest version.

docker-compose exec php8.1 vendor/bin/bdi detect drivers
docker-compose exec php8.2 vendor/bin/bdi detect drivers

## Credits

Expand Down
9 changes: 9 additions & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
version: "3"
services:

php8.2:
tty: true
build:
context: .
args:
- PHP_VERSION=8.2-rc
volumes:
- .:/var/www/html

php8.1:
tty: true
build:
Expand Down

0 comments on commit e85836e

Please sign in to comment.