Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to pass kernel options and manager options to panther driver #6

Closed
wants to merge 3 commits into from

Conversation

phcorp
Copy link
Contributor

@phcorp phcorp commented Mar 9, 2021

This fixes #5

PR on robertfausk/mink-panther-driver: robertfausk/mink-panther-driver#20

Testing the pull-request

update your composer.json with following values :

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/phcorp/behat-panther-extension"
        },
        {
            "type": "vcs",
            "url": "https://github.com/phcorp/mink-panther-driver"
        }
    ],
    "require-dev": {
        "robertfausk/behat-panther-extension": "dev-feat/all-panther-options"
    }
}

and run $ composer update robertfausk/behat-panther-extension

update your behat.yaml, for instance:

default:
    extensions:
        Robertfausk\Behat\PantherExtension: ~
        Behat\MinkExtension:
            sessions:
                my_session:
                    panther:
                        options:
                            browser: 'chrome'
                        manager_options:
                            connection_timeout_in_ms: 5000
                            request_timeout_in_ms: 120000

then lanch your tests suites (e.g. APP_ENV=test bin/behat)

additional options should be taken into account

Merging

A new version of mink-panther-driver sould be released first (see robertfausk/mink-panther-driver#20).

Commit c717075 should be omitted before merging.

@phcorp phcorp force-pushed the feat/all-panther-options branch from 2b5f626 to c717075 Compare March 9, 2021 16:19
@robertfausk
Copy link
Owner

Merged in c163b73 as suggested without the composer repository workaround.
Thank you @phcorp!

@phcorp
Copy link
Contributor Author

phcorp commented Mar 15, 2021

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panther kernel options and manager options
2 participants